Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request aligns the cloud picker's UI with other pickers in the extension by standardizing the default agent icon and adding billing information to model selections.
Changes:
- Updated the default custom agent icon from 'file-text' to 'agent' and removed its description field to match the partner agent picker styling
- Added billing multiplier descriptions (e.g., "2x") to model items to help users understand cost implications
| const modelItems: vscode.ChatSessionProviderOptionItem[] = models.value.map(model => ({ | ||
| id: model.id, | ||
| name: model.name, | ||
| description: `${model.billing.multiplier}x`, |
There was a problem hiding this comment.
The billing.multiplier property is accessed without optional chaining, which could cause a runtime error if the billing object is undefined or null. In a similar location (src/extension/agents/copilotcli/node/copilotCli.ts:162), the same property is accessed with optional chaining: model.billing?.multiplier. Consider using the same pattern here for consistency and safety.
Suggested change
| description: `${model.billing.multiplier}x`, | |
| description: `${model.billing?.multiplier}x`, |
chrmarti
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Adjust the cloud picker alignment to match the layout of other pickers and update the icon for the default agent. Additionally, include a description for model items indicating their billing multiplier.microsoft/vscode#291526